Don't check units during initialization #3119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AayushSabharwal can you incorporate this post your PR? |
|
@AayushSabharwal can you rebase this onto your larger change? |
|
Sure, sorry for missing this earlier. |
...because initialization problems don't correctly handle units and units have already been checked during system initialization.
AayushSabharwal
force-pushed
the
units_init
branch
from
bb46df0 to
f7bf33a
Compare
src/systems/problem_utils.jl
Outdated
| @@ -396,7 +396,7 @@ Keyword arguments: | |||
| - `eval_module`: If `eval_expression == true`, the module to `eval` into. Otherwise, the module | |||
| in which to generate the `RuntimeGeneratedFunction`. | |||
| - `fully_determined`: Override whether the initialization system is fully determined. | |||
| - `check_units`: Enable or disable unit checks. | |||
| - `check_units`: Enable or disable unit checks when constructing the initialization problem. | |||
There was a problem hiding this comment.
change the name to check_initialization_units?
ChrisRackauckas
approved these changes
Oct 28, 2024
|
I have the format commit ready. Once tests pass, I'll push it and merge so we don't rerun CI unnecessarily. |
|
All tests pass, barring the homotopy continuation ones fixed in #3158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because initialization problems don't correctly handle units and units have already been checked during system initialization.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Fixes #3086